Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump deps for sec updates #1082

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Bump deps for sec updates #1082

merged 1 commit into from
Nov 16, 2023

Conversation

marcello33
Copy link
Contributor

Description

Bump some dependencies.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply
  • Created a task in Jira and informed the team for implementation in Erigon client (if applicable)
  • Includes RPC methods changes, and the Notion documentation has been updated

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

@marcello33 marcello33 changed the base branch from master to develop November 16, 2023 09:21
@marcello33 marcello33 requested a review from a team November 16, 2023 09:24
@codecov Codecov
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (3c97a5b) 56.01% compared to head (752718d) 55.97%.
Report is 3 commits behind head on develop.

Files Patch % Lines
internal/cli/flagset/flagset.go 0.00% 14 Missing ⚠️
params/config.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1082      +/-   ##
===========================================
- Coverage    56.01%   55.97%   -0.04%     
===========================================
  Files          658      658              
  Lines       114437   114437              
===========================================
- Hits         64098    64054      -44     
- Misses       46492    46534      +42     
- Partials      3847     3849       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcello33 marcello33 merged commit d345879 into develop Nov 16, 2023
13 of 15 checks passed
@marcello33 marcello33 mentioned this pull request Nov 16, 2023
Closed
@marcello33 marcello33 deleted the mardizzone/sec-updates branch November 16, 2023 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raneet10 Raneet10 Raneet10 approved these changes

@pratikspatil024 pratikspatil024 pratikspatil024 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcello33 @Raneet10 @pratikspatil024